Skip to content

Conversation

dcci
Copy link
Member

@dcci dcci commented Dec 19, 2015

Initial FreeBSD port of stdlib/FreeBSDlibc.
Thanks!

Davide

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not do an 'or' and add this to the previous 'if' statement? I expect these three libraries to be buildable on any unix-y system.

@gribozavr
Copy link
Contributor

@dcci Thank you for your patch!

I don't like the duplication of the overlay code. Is there a way you can think of we could share the code between FreeBSD and Linux, and, potentially, Darwin?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also TestRunPredicate below that should be updated, and then you should be able to write a test like this validation-test/stdlib/StdlibUnittestLinux.swift but for FreeBSD.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

@dcci
Copy link
Member Author

dcci commented Dec 20, 2015

The main difference is the module map and __environ. There's probably a way to make more code to be shared, I'll think about it harder between today and tomorrow and submit a new patch

Thanks for your review!

Davide

@gribozavr
Copy link
Contributor

@dcci Thanks! I would be much happier with more complex CMake code than duplication of actual overlay code.

@dcci dcci closed this Dec 21, 2015
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
[Stress tester XFails] Update XFails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants