Skip to content

Conversation

flyin1600
Copy link

… tag, when encountered in AST it is processed in line

Added new tag <{TEMPLATE_FILE_NAME} for processing embedded templates in gyb templates. Created a new class to represent a template, and when they are encountered in the AST they are processed in place in a new ParseContext

@hughbe
Copy link
Contributor

hughbe commented Feb 10, 2017

@swift-ci please python lint

@flyin1600 flyin1600 force-pushed the gyb-embedded-templates branch from e91ca95 to 95033ae Compare February 10, 2017 20:18
@flyin1600
Copy link
Author

linted

@CodaFi
Copy link
Contributor

CodaFi commented Feb 10, 2017

@swift-ci please python lint

@flyin1600
Copy link
Author

I did go back and python lint it, and it looks like it's passing lint now, but it's been waiting status on the Linux and OS X platform tests since Friday, and ideas why?

@hughbe
Copy link
Contributor

hughbe commented Feb 13, 2017

There's a bunch of bugs with the GitHub triggers :(

You need to manually trigger CI (see below). I think you'll also need to get commit access to trigger CI (https://swift.org/blog/swift-commit-access/)

@hughbe
Copy link
Contributor

hughbe commented Feb 13, 2017

@swift-ci please smoke test

1 similar comment
@hughbe
Copy link
Contributor

hughbe commented Feb 13, 2017

@swift-ci please smoke test

@flyin1600
Copy link
Author

I tried to build and run tests locally but my MacBook Pro kernel panics every time, I can redo it and say exactly which library if needed. Is that a known issue?

is there a way to run the smoke test without building all of swift?

@flyin1600
Copy link
Author

I see your edit, I'll take a look, thanks!

@flyin1600
Copy link
Author

so CI is running and it appears to be failing at the same point it fails to build on my local machine. Every time I reach this point in the build, it hangs and I have 5 python threads spinning at 100% cpu

[727/1180] cd /Users/andrewlipiecki/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/stdlib/public/SwiftRemoteMirror && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/lipo -create -output /Users/andrewlipiecki/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/./lib/swift/macosx/libswiftRemoteMirror.dylib /Users/andrewlipiecki/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/lib/swift/macosx/x86_64/libswiftRemoteMirror.dylib && codesign -f -s - /Users/andrewlipiecki/build/Ninja-RelWithDebInfoAssert/swift-macosx-x86_64/./lib/swift/macosx/libswiftRemoteMirror.dylib

This is running lipo and code signing...so I don't see how it could have anything to do with my change to gyb. I'm going to file a GitHub issue for this.

@flyin1600
Copy link
Author

I apparently don't have permission to create an issue, as I don't see the Issues tab in the swift repo

@gottesmm
Copy link
Contributor

@flyin1600 We use a separate bug tracker. bugs.swift.org

@flyin1600
Copy link
Author

thank you, I'll file something over there

@flyin1600 flyin1600 force-pushed the gyb-embedded-templates branch from 95033ae to a43d12e Compare April 6, 2017 06:02
… tag, when encountered in AST it is processed in line
@flyin1600 flyin1600 force-pushed the gyb-embedded-templates branch from a43d12e to 7a4e036 Compare April 6, 2017 19:59
@flyin1600
Copy link
Author

flyin1600 commented Apr 7, 2017

can someone please kick off a smoke test? thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants