[Build System: update-checkout] avoid multiprocessing when n is 1 #78896
Conversation
There's no need to fiddle with locks etc. when there's no actual parallelism going on.
|
@swift-ci please smoke test |
|
For context, this helped me work around an issue where I kept getting stuck waiting on a lock (for reasons I don't know). |
MaxDesiatov
left a comment
MaxDesiatov
left a comment
There was a problem hiding this comment.
Seems fine, but lack of testing worries me. I'm not proficient enough with Python to suggest a concrete testing strategy though.
MaxDesiatov
added
python
Does update-checkout have tests? |
|
It does seem to have some tests here https://github.com/swiftlang/swift/tree/main/utils/update_checkout/tests |
The mock repo is configured with the no-reply@swift.org email address. If the user has globally configured git to sign commits this won't match the signature, preventing the tests from running properly.
|
@swift-ci please smoke test |
|
@MaxDesiatov Sorry about the delay. Added some single threaded versions of the existing tests. Let me know if you have any other comments. |
AnthonyLatsis
removed
the
needs tests
|
@swift-ci smoke test linux |
There was a problem hiding this comment.
LGTM, but please wait for a review from Eric Evan too. Feel free to ping them if the PR stalls.
|
@swift-ci smoke test linux |
|
Closing this, as using a python version >3.9 fixes the multiprocessing issues. |
Pull request was closed
3 participants
There's no need to fiddle with locks etc. when there's no actual parallelism going on.