Add type annotations to ProductPipeline in build-script
#82780
+29
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents possible runtime type errors and helped uncovering #82777. It also server as an improvement o documentation, as provides inferred type annotations for users of this class and callers of its methods.
MaxDesiatov
requested review from
justice-adams-apple and
shahmishal
as code owners
MaxDesiatov
commented
Jul 3, 2025
|
|
||
| for i in range(len(inferred_pipeline_list)): | ||
| pipeline = inferred_pipeline_list[i] | ||
| inferred_pipeline = inferred_pipeline_list[i] |
There was a problem hiding this comment.
renaming pipeline here as otherwise we essentially rebound this variable with values of different type, which I don't think plays well with type annotations
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
|
@swift-ci test windows |
|
@swift-ci build toolchain amazon linux 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents possible runtime type errors and helped uncovering #82777. It also server as an improvement o documentation, as provides inferred type annotations for users of this class and callers of its methods.