[unittests] Fix compilation of Runtime unittests #84235
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR#78516 performed a rename from `swiftRuntime` to `swiftRuntimeCore` but might have skipped these two instances because the code is rarely compiled in Darwin platforms (and it is compiled in Linux/Windows platforms either). The code on the runtime unittests seems to be associated with the SDK overlays being built (either static or dynamic), which none are for Darwin platforms. Other platforms should build the dynamic SDK overlay, but the file is surrounded with checks for `__APPLE__` and `__MACH__`. The normal CI would never hit this file, but someone might while building the static or dynamic SDK overlay if they so request it to the `build-script`.
Contributor
Author
|
@swift-ci please smoke test |
al45tair
approved these changes
Sep 12, 2025
Contributor
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR#78516 performed a rename from
swiftRuntimetoswiftRuntimeCorebut might have skipped these two instances because the code is rarely compiled in Darwin platforms (and it is not compiled in Linux/Windows platforms either). The code on the runtime unittests seems to be associated with the SDK overlays being built (either static or dynamic), which none are for Darwin platforms by default. Other platforms should build the dynamic SDK overlay, but the file is surrounded with checks for__APPLE__and__MACH__.The normal CI would never hit this file, but someone might while building the static or dynamic SDK overlay if they so request it to the
build-script.