Skip to content

Optimize Specializations of Variadic Generics by Eliminating Parameter Packs #84513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+2,353 −50
Open

Optimize Specializations of Variadic Generics by Eliminating Parameter Packs #84513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e87bede
Bridging: APIs for PackSpecialization pass
aidan-hall Sep 11, 2025
e58b1eb
Create Pack Specialisation pass
aidan-hall Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions SwiftCompilerSources/Sources/AST/Type.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,8 @@ extension TypeProperties {
public var isExistentialMetatype: Bool { rawType.bridged.isExistentialMetatypeType() }
public var isDynamicSelf: Bool { rawType.bridged.isDynamicSelf()}
public var isBox: Bool { rawType.bridged.isBox() }
public var isPack: Bool { rawType.bridged.isPack() }
public var isSILPack: Bool { rawType.bridged.isSILPack() }

public var canBeClass: Type.TraitResult { rawType.bridged.canBeClass().result }

Expand Down Expand Up @@ -263,6 +265,14 @@ extension TypeProperties {
public func checkConformance(to protocol: ProtocolDecl) -> Conformance {
return Conformance(bridged: rawType.bridged.checkConformance(`protocol`.bridged))
}

public var containsSILPackExpansionType: Bool {
return rawType.bridged.containsSILPackExpansionType()
}

public var isSILPackElementAddress: Bool {
return rawType.bridged.isSILPackElementAddress()
}
}

public struct TypeArray : RandomAccessCollection, CustomReflectable {
Expand Down
1 change: 1 addition & 0 deletions SwiftCompilerSources/Sources/Optimizer/FunctionPasses/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,5 @@ swift_compiler_sources(Optimizer
StripObjectHeaders.swift
TempLValueElimination.swift
TempRValueElimination.swift
PackSpecialization.swift
)
4 changes: 2 additions & 2 deletions SwiftCompilerSources/Sources/Optimizer/FunctionPasses/ConstantCapturePropagation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ private func specializeClosure(specializedName: String,
newParams.append(contentsOf: nonConstantArguments.map { partialApply.parameter(for: $0)! })

let isGeneric = newParams.contains { $0.type.hasTypeParameter } ||
callee.convention.results.contains { $0.type.hasTypeParameter() } ||
callee.convention.errorResult?.type.hasTypeParameter() ?? false
callee.convention.results.contains { $0.type.hasTypeParameter } ||
callee.convention.errorResult?.type.hasTypeParameter ?? false

let specializedClosure = context.createSpecializedFunctionDeclaration(from: callee,
withName: specializedName,
Expand Down
Loading