[6.2][TypeChecker] Avoid checking lazy property accessors if they haven't … #84654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
bnbarham
approved these changes
Oct 2, 2025
…been synthesized yet Ttheir availability is going to match the property itself. This is a workaround for lazy type-checking because synthesis of accessors for such properties requires a reference to `self` which won't be available because pattern binding for the variable was skipped. Resolves: rdar://129359362 Resolves: rdar://159463230 Resolves: swiftlang#84041 (cherry picked from commit 6e7de5c)
xedin
force-pushed
the
rdar-129359362-6.2
branch
from
a0e586d to
d91b464
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…been synthesized yet
Explanation:
Their availability is going to match the property itself. This is a workaround for lazy type-checking because synthesis of accessors for such properties requires a reference to
selfwhich won't be available because pattern binding for the variable was skipped.Resolves: rdar://129359362 rdar://159463230 Nullptr crash in
swift::SynthesizeAccessorRequest::evaluate#84041Main Branch PR: [TypeChecker] Avoid checking lazy property accessors if they haven't … #84066
Risk: Low. This is a narrow workaround for lazy type-checking (not enabled by default).
Reviewed By: @tshortli
Testing: Added new test-cases to the suite.
(cherry picked from commit 6e7de5c)