Skip to content

[Frontend] Don't enable EmbeddedRestrictions warnings under -suppress-warnings #84754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2025
Merged

[Frontend] Don't enable EmbeddedRestrictions warnings under -suppress-warnings #84754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Frontend/CompilerInvocation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2646,7 +2646,7 @@ static bool ParseDiagnosticArgs(DiagnosticOptions &Opts, ArgList &Args,

// If the "embedded" flag was provided, enable the EmbeddedRestrictions
// warning group. This group is opt-in in non-Embedded builds.
if (isEmbedded(Args)) {
if (isEmbedded(Args) && !Args.hasArg(OPT_suppress_warnings)) {
Opts.WarningsAsErrorsRules.push_back(
WarningAsErrorRule(WarningAsErrorRule::Action::Disable,
"EmbeddedRestrictions"));
Expand Down
4 changes: 3 additions & 1 deletion test/embedded/restrictions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// RUN: %target-typecheck-verify-swift -Wwarning EmbeddedRestrictions -verify-additional-prefix nonembedded-
// RUN: %target-typecheck-verify-swift -enable-experimental-feature Embedded -verify-additional-prefix embedded-

// RUN: %target-swift-frontend -typecheck %s -suppress-warnings -enable-experimental-feature Embedded -DSUPPRESS_WEAK
// REQUIRES: swift_in_compiler
// REQUIRES: swift_feature_Embedded

Expand Down Expand Up @@ -54,12 +54,14 @@ struct SomeStruct {
public class MyClass { }

public struct MyStruct {
#if !SUPPRESS_WEAK
var normalVar: MyClass
weak var weakVar: MyClass? // expected-nonembedded-warning {{attribute 'weak' cannot be used in Embedded Swift}}
// expected-embedded-error@-1 {{attribute 'weak' cannot be used in Embedded Swift}}

unowned var unownedVar: MyClass // expected-nonembedded-warning {{attribute 'unowned' cannot be used in Embedded Swift}}
// expected-embedded-error @-1{{attribute 'unowned' cannot be used in Embedded Swift}}
#endif

unowned(unsafe) var unownedUnsafe: MyClass
}
Expand Down