Fix 82618 #84789
Draft
Fix 82618 #84789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickolas-pohilets
requested review from
a team,
hborla,
jckarter,
kavon,
slavapestov and
xedin
as code owners
kavon
reviewed
Oct 23, 2025
Comment on lines
+1672
to
+1675
| namespace { | ||
| class ConversionClosureEmitter: public Lowering::ExprVisitor<ConversionClosureEmitter, Expr*> { | ||
| ASTContext &Context; | ||
| OpaqueValueExpr *OrigValue; |
There was a problem hiding this comment.
AST transformations and non-trivial expression synthesis should happen in Sema, not SILGen. One of the main reasons why is that SILGen happens after the ASTVerifier has run.
One way to do this is to define an ASTWalker and have it run during TypeCheckPrimaryFileRequest::evaluate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds missing functionality to generate code for
KeyConversionandValueConversioninCollectionUpcastConversionExpr. New built-ins have been added to the standard library as@_alwaysEmitIntoClientfor backwards compatibility.