Move registerStdSpanTypeMapping to SwiftifyInfoPrinter (NFC) #84842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`registerStdSpanTypeMapping` used to be a lambda inside `swiftify`. By moving it, along with the `typeMapping` state, inside `SwiftifyInfoPrinter` we will simplify changes necessary to support `_SwiftifyImportProtocol` in ClangImporter.
hnrklssn
requested review from
Xazax-hun,
beccadax,
egorzhdan,
fahadnayyar,
ian-twilightcoder,
j-hui,
susmonteiro and
zoecarver
as code owners
Member
Author
|
@swift-ci please smoke test |
j-hui
approved these changes
Oct 11, 2025
Member
Author
|
@swift-ci please smoke test windows platform |
Xazax-hun
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerStdSpanTypeMappingused to be a lambda insideswiftify. By moving it, along with thetypeMappingstate, insideSwiftifyInfoPrinterwe will simplify changes necessary to support_SwiftifyImportProtocolin ClangImporter.Extracted from #79510