[NameLookup] Prefer property wrapper over attached macro on local var #84854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce CustomAttrOwner that can store either a Decl for an attached attribute, or a DeclContext for e.g a type or closure attribute. Store this on CustomAttr such that we can query it from the name lookup requests.
We don't properly support peer declarations in local contexts, as such if we have both a property wrapper and macro with a given name on a local var, let's prefer the property wrapper. rdar://148782639
hamishknight
requested review from
AnthonyLatsis,
CodaFi,
DougGregor,
Xazax-hun,
beccadax,
bnbarham,
egorzhdan,
fahadnayyar,
hborla,
ian-twilightcoder,
j-hui,
rintaro,
slavapestov,
susmonteiro,
xedin,
xymus and
zoecarver
as code owners
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't properly support peer declarations in local contexts, as such if we have both a property wrapper and macro with a given name on a local var, let's prefer the property wrapper.
rdar://148782639