[Parse] Avoid setting closure in SourceLoc if missing
#84855
Merged
+45
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
CodaFi,
DougGregor,
bnbarham,
hborla,
rintaro,
slavapestov and
xedin
as code owners
rintaro
approved these changes
Oct 13, 2025
Clients should be able to handle closures without a valid `in` SourceLoc, let's avoid setting it to a recovery location. This avoids crashing in cases where we set an `in` loc that's after the closure's end loc.
hamishknight
force-pushed
the
loc-ness-monster
branch
from
a01a4c6 to
b83cf1e
Compare
|
@swift-ci please test |
|
@swift-ci please SourceKit stress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients should be able to handle closures without a valid
inSourceLoc, let's avoid setting it to a recovery location. This avoids crashing in cases where we set aninloc that's after the closure's end loc, fixing a stress tester regression from #84278.