[CS] Penalize implicit pointer conversions to generic parameter types #84907
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
force-pushed
the
fixed-point
branch
from
0cae4c6 to
8b33233
Compare
xedin
reviewed
Oct 15, 2025
We ought to consider outright banning these conversions if the destination is a generic parameter type, but for now let's penalize them such that we don't end up with ambiguities if you're doing an implicit pointer conversion through an identity generic function. rdar://161205293
hamishknight
force-pushed
the
fixed-point
branch
from
8b33233 to
77a5938
Compare
|
@swift-ci please test |
xedin
approved these changes
Oct 16, 2025
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ought to consider outright banning these conversions if the destination is a generic parameter type, but for now let's penalize them such that we don't end up with ambiguities if you're doing an implicit pointer conversion through an identity generic function.
rdar://161205293