Skip to content

[Test][SILOptimizer] Fix di-conditional-destroy-scope test #84941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2025
Merged

[Test][SILOptimizer] Fix di-conditional-destroy-scope test #84941

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4426bd5
[Test][SILOptimizer] Fix di-conditional-destroy-scope test
ramonasuncion Oct 15, 2025
ea38612
[Test][SILOptimizer] Quote filter function name
ramonasuncion Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/SILOptimizer/di-conditional-destroy-scope.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// RUN: %target-swift-frontend -Xllvm -sil-print-types -emit-sil %s -Onone -Xllvm \
// RUN: -sil-print-after=raw-sil-inst-lowering -Xllvm \
// RUN: -sil-print-functions=$s2fs36RecursibleDirectoryContentsGeneratorC4path10fileSystemAcA12AbsolutePathV_AA04FileH0_ptKc33_F8B132991B28208F48606E87DC165393Llfc \
// RUN: -Xllvm -sil-print-types -Xllvm -sil-print-debuginfo -o /dev/null 2>&1 | %FileCheck %s
// RUN: -sil-print-functions='$s2fs36RecursibleDirectoryContentsGeneratorC4path10fileSystemAcA12AbsolutePathV_AA04FileH0_ptKc33_F988CDD4B32A48D8BEE265DC43B61560Llfc' \
// RUN: -Xllvm -sil-print-types -Xllvm -sil-print-debuginfo -o /dev/null -module-name fs 2>&1 | %FileCheck %s

// REQUIRES: objc_interop
// REQUIRES: foundation


Copy link
Member

@hnrklssn hnrklssn Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the diffs are due to this removed blank line changing the line numbers for each following line. If we put it back in the diff can be reduced a bit.

Copy link
Member Author

@ramonasuncion ramonasuncion Nov 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that would do it. Thanks. 😵‍💫

// CHECK: [[ADR:%.*]] = ref_element_addr %{{.*}} : $RecursibleDirectoryContentsGenerator, #RecursibleDirectoryContentsGenerator.fileSystem, loc {{.*}}:39:5, scope [[SCOPE:[0-9]+]]
Expand Down