Skip to content

Conversation

charles-zablit
Copy link
Contributor

This patch updates the Wix version to 5.0.2 from 4.0.6. The movitation for this update is the introduction of Files which allows to generate components for all the files in a directory instead of having to list them manually.

@charles-zablit charles-zablit self-assigned this Oct 16, 2025
@charles-zablit charles-zablit added the Windows Platform: Windows label Oct 16, 2025
@charles-zablit
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we don't want to move to 5.x yet. This is something that is a MUCH larger and riskier change.

@charles-zablit
Copy link
Contributor Author

no, we don't want to move to 5.x yet. This is something that is a MUCH larger and riskier change.

What are the main concerns here? From the Wix docs:

WiX v5 is highly compatible with WiX v4.

Without Wix v5, we have to add ~50 entries manually for all the pip files in swiftlang/swift-installer-scripts#447.

@compnerd
Copy link
Member

Ultimately, this is something that I am responsible for, and I don't think that this change is reasonable on its own. when this is done, we should re-author the entire installer manifest set and go through it with sufficient amount of testing for the major upgrade. We have in the past contracted this through FireGiant, and I think that this change should do the same. I think it is better to add the additional rules for the PIP bits for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Windows Platform: Windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants