Add CAS support #84970
Open
Add CAS support #84970
+31
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
compnerd
reviewed
Oct 16, 2025
utils/build.ps1
Outdated
Comment on lines
1626
to
1627
| $CXXFLAGS += @("/clang:-fdepscan=inline", "/clang:-fdepscan-include-tree", | ||
| "-Xclang", "-fcas-path", "-Xclang", $CASPath) |
There was a problem hiding this comment.
Suggested change
| $CXXFLAGS += @("/clang:-fdepscan=inline", "/clang:-fdepscan-include-tree", | |
| "-Xclang", "-fcas-path", "-Xclang", $CASPath) | |
| $CXXFLAGS += if ($UseGNUDriver) { | |
| @("-fdepscan=inline", "-fdepscan-include-tree", "-Xclang", "-fcas-path", "-Xclang", $CASPath); | |
| } else { | |
| @("/clang:-fdepscan=inline", "/clang:-fdepscan-include-tree", "-Xclang", "-fcas-path", "-Xclang", $CASPath); | |
| } |
hjyamauchi
force-pushed
the
buildps1cas
branch
from
5bf18b2 to
0b66be9
Compare
|
@swift-ci please test |
|
@swift-ci please test macos platform |
compnerd
reviewed
Oct 17, 2025
hjyamauchi
force-pushed
the
buildps1cas
branch
from
0b66be9 to
8e8055e
Compare
|
@swift-ci please test |
|
PTAL @compnerd |
mhegazy
reviewed
Oct 20, 2025
| @@ -560,6 +564,10 @@ if (-not $PinnedBuild) { | |||
|
|
|||
| $PinnedToolchain = [IO.Path]::GetFileNameWithoutExtension($PinnedBuild) | |||
|
|
|||
| if ($EnableCAS -and ($UseHostToolchain -or ($PinnedVersion -ne "0.0.0"))) { | |||
There was a problem hiding this comment.
nit. would not it be better to check llvm version instead llvm-project/llvm/utils/lit.py --version?
There was a problem hiding this comment.
This intends to check for a swift main-branch build which is currently the only swift build/repo where it currently works and so it's more about the swift version than the LLVM version
compnerd
reviewed
Oct 23, 2025
| @@ -158,6 +158,10 @@ param | |||
| [ValidatePattern('^\d+(\.\d+)*$')] | |||
| [string] $SCCacheVersion = "0.10.0", | |||
|
|
|||
| # Build with CAS | |||
| [switch] $EnableCAS = $false, | |||
| [string] $CASPath = "S:\cas", | |||
There was a problem hiding this comment.
Please use ImageRoot rather than S:. The swift.org CI uses a different root (T:).
I wonder if we should just make this a required parameter from the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.