Skip to content

Conversation

@ramonasuncion
Copy link
Member

Partially address: #84407

@ramonasuncion
Copy link
Member Author

@swift-ci please smoke test

Copy link
Member

@hnrklssn hnrklssn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _LAX versions were added in this commit:

commit d4ffaa375991c771412856b809b74bc157bd63bd
Author: Jordan Rose <jordan_rose@apple.com>
Date:   Thu Jun 9 20:19:55 2016 -0700

    [test] Check LD_LIBRARY_PATH a little less strictly.

    LD_LIBRARY_PATH is one of the few environment variables the LLVM 'lit'
    tool /doesn't/ strip out, presumably because on some Linux systems
    it's necessary to run some of the built products being tested.
    However, the Swift driver also uses LD_LIBRARY_PATH when providing -L
    options to the script interpreter on Linux. Weaken some of our tests
    when there's an LD_LIBRARY_PATH in the environment.

    (There are similar environment variables on OS X, but we don't have to
    do anything special there because lit /does/ strip those out. This is
    presumably okay because all of LLVM's load-time dependencies on OS X
    are in standard system locations.)

    https://bugs.swift.org/browse/SR-813

It's never necessary to check both the LINUX prefixes and the LINUX_LAX prefixes, because if the LINUX checks pass, the LINUX_LAX checks will also pass. There are cases where LINUX_LAX passes but LINUX does not, however.

I would propose either keeping only the LINUX_LAX versions, because it's clearly not that important to assert that there is nothing else in the LD_LIBRARY_PATH. The other option would be to explicitly unset LD_LIBRARY_PATH for each test using env -u LD_LIBRARY_PATH and skip the LINUX_LAX option. That might break on some Linux platforms though (I'm not entirely sure).

@ramonasuncion
Copy link
Member Author

@swift-ci please smoke test

@hnrklssn
Copy link
Member

hnrklssn commented Nov 7, 2025

Timed Out Tests (1):
  lldb-shell :: Breakpoint/jit-loader_rtdyld_elf.test

@hnrklssn
Copy link
Member

hnrklssn commented Nov 7, 2025

@swift-ci please smoke test windows platform

@ramonasuncion
Copy link
Member Author

The test failed again, even though it's unsupported... 😕

UNSUPPORTED: Swift(windows-x86_64) :: Driver/options-interpreter.swift (2138 of 12143)

@hnrklssn
Copy link
Member

hnrklssn commented Nov 8, 2025

Test Suite 'CompilationDatabaseTests' started at 2025-11-08 04:20:13.069

Test Case 'CompilationDatabaseTests.testJSONCompilationDatabaseCoding' started at 2025-11-08 04:20:13.069

C:\Users\swift-ci\jenkins\workspace\swift-PR-windows\sourcekit-lsp\Tests\BuildServerIntegrationTests\CompilationDatabaseTests.swift:148: error: CompilationDatabaseTests.testJSONCompilationDatabaseCoding : XCTAssertEqual failed: ("JSONCompilationDatabase(pathToCommands: [b -- file:///C:/a/: [0], b -- file:///C:/c/: [1]], commands: [BuildServerIntegration.CompilationDatabaseCompileCommand(directory: "a", filename: "b", commandLine: [], output: nil), BuildServerIntegration.CompilationDatabaseCompileCommand(directory: "c", filename: "b", commandLine: [], output: nil)], compileCommandsDirectory: file:///C:/)") is not equal to ("JSONCompilationDatabase(pathToCommands: [b -- file:///C:/a/: [0], b -- file:///C:/Users/swift-ci/jenkins/workspace/swift-PR-windows/sourcekit-lsp/: [1]], commands: [BuildServerIntegration.CompilationDatabaseCompileCommand(directory: "a", filename: "b", commandLine: [], output: nil), BuildServerIntegration.CompilationDatabaseCompileCommand(directory: "c", filename: "b", commandLine: [], output: nil)], compileCommandsDirectory: file:///C:/)") - 

Test Case 'CompilationDatabaseTests.testJSONCompilationDatabaseCoding' failed (0.013 seconds)

Test Suite 'CompilationDatabaseTests' failed at 2025-11-08 04:20:13.082

	 Executed 1 test, with 1 failure (0 unexpected) in 0.013 (0.013) seconds

Test Suite 'Selected tests' failed at 2025-11-08 04:20:13.082

	 Executed 1 test, with 1 failure (0 unexpected) in 0.013 (0.013) seconds

Pretty sure it's unrelated. Not sure if it's broken on main, or just flaky. Sometimes you gotta give it a couple of attempts.

@hnrklssn
Copy link
Member

hnrklssn commented Nov 8, 2025

@swift-ci please smoke test windows platform

@hnrklssn hnrklssn merged commit d494a31 into swiftlang:main Nov 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants