-
Notifications
You must be signed in to change notification settings - Fork 10.6k
[Test][Driver] Clean up FileCheck prefixes for internal shell #84988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Test][Driver] Clean up FileCheck prefixes for internal shell #84988
Conversation
|
@swift-ci please smoke test |
hnrklssn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The _LAX versions were added in this commit:
commit d4ffaa375991c771412856b809b74bc157bd63bd
Author: Jordan Rose <jordan_rose@apple.com>
Date: Thu Jun 9 20:19:55 2016 -0700
[test] Check LD_LIBRARY_PATH a little less strictly.
LD_LIBRARY_PATH is one of the few environment variables the LLVM 'lit'
tool /doesn't/ strip out, presumably because on some Linux systems
it's necessary to run some of the built products being tested.
However, the Swift driver also uses LD_LIBRARY_PATH when providing -L
options to the script interpreter on Linux. Weaken some of our tests
when there's an LD_LIBRARY_PATH in the environment.
(There are similar environment variables on OS X, but we don't have to
do anything special there because lit /does/ strip those out. This is
presumably okay because all of LLVM's load-time dependencies on OS X
are in standard system locations.)
https://bugs.swift.org/browse/SR-813
It's never necessary to check both the LINUX prefixes and the LINUX_LAX prefixes, because if the LINUX checks pass, the LINUX_LAX checks will also pass. There are cases where LINUX_LAX passes but LINUX does not, however.
I would propose either keeping only the LINUX_LAX versions, because it's clearly not that important to assert that there is nothing else in the LD_LIBRARY_PATH. The other option would be to explicitly unset LD_LIBRARY_PATH for each test using env -u LD_LIBRARY_PATH and skip the LINUX_LAX option. That might break on some Linux platforms though (I'm not entirely sure).
|
@swift-ci please smoke test |
|
|
@swift-ci please smoke test windows platform |
|
The test failed again, even though it's unsupported... 😕 |
Pretty sure it's unrelated. Not sure if it's broken on main, or just flaky. Sometimes you gotta give it a couple of attempts. |
|
@swift-ci please smoke test windows platform |
Partially address: #84407