[SE-0495, SILGen] Only emit C-compatible entrypoints for @c definitions. #84989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
AnthonyLatsis,
hborla,
jckarter,
kavon,
rjmccall,
slavapestov and
xedin
as code owners
Member
Author
|
@swift-ci please smoke test |
When defining a C-compatible function with `@c`, we were emitting a Swift function along with a C-compatible thunk. Stop doing that, and instead only produce the C-compatible function. All uses of the function will go through that C interface, just like if the function were declared in C. This also applies to `@c @implementation` functions, which are declared in C but implemented in Swift. It does *not* apply to `@_cdecl`, which will continue to produce both the Swift function and C thunk to prevent an ABI break. Fixes rdar://158888024.
DougGregor
force-pushed
the
c-only-c-entrypoint
branch
from
a58a967 to
4be74c7
Compare
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a C-compatible function with
@c, we were emitting a Swift function along with a C-compatible thunk. Stop doing that, and instead only produce the C-compatible function. All uses of the function will go through that C interface, just like if the function were declared in C.This also applies to
@c @implementationfunctions, which are declared in C but implemented in Swift. It does not apply to@_cdecl, which will continue to produce both the Swift function and C thunk to prevent an ABI break.Fixes rdar://158888024.