Optimizer: remove the CopyForwarding pass #85005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eeckstein
requested review from
AnthonyLatsis,
Xazax-hun,
adrian-prantl,
egorzhdan,
fahadnayyar,
hnrklssn,
j-hui,
jckarter,
rjmccall,
susmonteiro and
zoecarver
as code owners
eeckstein
requested review from
aidan-hall,
atrick,
meg-gupta and
nate-chandler
and removed request for
AnthonyLatsis,
Xazax-hun,
adrian-prantl,
egorzhdan,
fahadnayyar,
hnrklssn,
j-hui,
jckarter,
rjmccall,
susmonteiro and
zoecarver
|
@swift-ci smoke test |
|
@swift-ci apple silicon benchmark |
|
I'm loving all these PRs that are removing redundant/unused/marginal optimizer passes from the pipeline. Great job! |
meg-gupta
reviewed
Oct 20, 2025
lib/SIL/Utils/InstructionUtils.cpp
Outdated
| case SILInstructionKind::CopyAddrInst: { | ||
| auto *ca = cast<CopyAddrInst>(inst); | ||
| if (ca->getSrc()->getType().isTrivial(ca->getFunction())) | ||
| if (!ca->getSrc()->getType().hasArchetype()) |
There was a problem hiding this comment.
Doesn't this case still need refcounting effect ?
There was a problem hiding this comment.
good catch, thanks!
I fixed it
It only needs metadata if the copied type has an archetype
This pass removes `copy_addr` instructions. However, it has some problems which causes compiler crashes. It's not worth fixing these bugs because 1. Most copy_addrs can be eliminated by TempRValueElimination and TempLValueElimination. 2. Once we have opaque value we don't need copy_addr elimination, anyway. rdar://162212460
eeckstein
force-pushed
the
remove-copy-forwarding
branch
from
f5f159a to
7a70049
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pass removes
copy_addrinstructions.However, it has some problems which causes compiler crashes.
It's not worth fixing these bugs because
This PR also contains some improvements for TempRValueElimination to compensate for the missing CopyForwarding pass.
rdar://162212460