Skip to content

Conversation

@aschwaighofer
Copy link
Contributor

This flag can be used to gradually add the functionility that will allow use of protocol values in embedded mode.

This flag can be used to gradually add the functionility that will allow use of
protocol values in embedded mode.
@aschwaighofer
Copy link
Contributor Author

@swift-ci smoke test

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

is InitExistentialValueInst,
is ExistentialMetatypeInst:
throw Diagnostic(.embedded_swift_existential_type, instruction.operands[0].value.type, at: instruction.location)
if !context.options.enableEmbeddedSwiftExistentials {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

}

var enableEmbeddedSwiftExistentials: Bool {
hasFeature(.EmbeddedExistentials)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, too

@aschwaighofer
Copy link
Contributor Author

@swift-ci smoke test

1 similar comment
@aschwaighofer
Copy link
Contributor Author

@swift-ci smoke test

@aschwaighofer
Copy link
Contributor Author

@swift-ci smoke test macOS

@aschwaighofer
Copy link
Contributor Author

@swift-ci clean smoke test

@aschwaighofer aschwaighofer merged commit 7f36b58 into swiftlang:main Oct 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants