AST: Skip weak linking on Windows consistently #85015
Merged
+37
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
hborla,
jckarter,
slavapestov and
xedin
as code owners
tshortli
force-pushed
the
never-weak-link-on-windows
branch
3 times, most recently
from
fb53590 to
635dead
Compare
tshortli
force-pushed
the
never-weak-link-on-windows
branch
from
635dead to
76cead4
Compare
Always special-case Windows targets in `isAlwaysWeakImported()` instead of limiting the special case to declarations that are marked unavailable.
tshortli
force-pushed
the
never-weak-link-on-windows
branch
from
76cead4 to
f87aa53
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always special-case Windows targets in
isAlwaysWeakImported()instead of limiting the special case to declarations that are marked unavailable.