-
Notifications
You must be signed in to change notification settings - Fork 10.6k
Runtimes: in macOS smoke test point to module cache from compiler build #85038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Runtimes: in macOS smoke test point to module cache from compiler build #85038
Conversation
This will ensure we are not racing with other runs running on the same builders. Addresses rdar://163122836
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
|
It looks like that did not help, the issue still happens in the specified module cache |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The runtimes should all be pointing to the same cache path. They're building for the same target against the same sysroot, so the cached PCMs should all be consistent. This kind of smells like a bug somewhere in the PCM generation pipeline.
If we do want to allow folks to override the module-cache location, let's use the name Swift_MODULE_CACHE_DIR since it's controlling compiler behavior instead of toggling feature support in each of these libraries.
This will ensure we are not racing with other runs running on the same builders.
Addresses rdar://163122836