Sema: Custom diagnostic for var decls referencing a restricted type #85039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xymus
requested review from
hborla,
slavapestov,
tshortli and
xedin
as code owners
|
@swift-ci Please smoke test |
tshortli
reviewed
Oct 21, 2025
| "in a public or '@usableFromInline' conformance|" | ||
| "in an '@available' attribute here}1; " | ||
| "in an '@available' attribute here|" | ||
| "in a variable declaration marked public or in a '@frozen' or '@usableFromInline' context}1; " |
There was a problem hiding this comment.
I think we typically refer to these as properties in diagnostics, since it's not a local variable
There was a problem hiding this comment.
Ah right, I've updated it.
Replace the `here` part of the generic exportability diagnostic for variables with: `in a property declaration marked public or in a '@Frozen' or '@usableFromInline' context`. The full diagnostic now looks like: ``` error: cannot use struct 'ImportedType' in a property declaration marked public or in a '@Frozen' or '@usableFromInline' context; 'HiddenDependency' has been imported as implementation-only ``` This should be improved further to support implicitly exported memory layouts in non-library-evolution and embedded.
xymus
force-pushed
the
exportability-var-diag
branch
from
3904e5e to
2d339c1
Compare
|
@swift-ci Please smoke test |
xedin
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
herepart of the generic exportability diagnostic for variables with:in a property declaration marked public or in a '@frozen' or '@usableFromInline' context.The full diagnostic now looks like:
This should be improved further to support implicitly exported memory layouts in non-library-evolution and embedded.