OpaqueValues: add support for property wrappers #85054
Conversation
This effectively reverts 8ca5c83
|
@swift-ci smoke test macOS |
1 similar comment
|
@swift-ci smoke test macOS |
kavon
force-pushed
the
opaque-values/fixes-3
branch
from
94734ab to
a992f6e
Compare
|
@swift-ci test |
| } | ||
|
|
||
| /// WARNING: Do not use this from SILGen! | ||
| /// Use methods such as `isSILIndirect` or query the ParameterInfo instead. |
There was a problem hiding this comment.
Should the comment explain why not? :)
There was a problem hiding this comment.
It's a little hard to explain, but it's because SILFunctionConventions::isSILIndirect goes through the SILModuleConventions::isIndirectSILParam query, which correctly answers whether an argument is indirect. Similarly it will do that for SILResultInfo for indirect returns.
In the future, I'd like to revise SILFunctionConventions::getSILArgumentConvention , or possibly eliminate it. It was recently refactored in 65e2e8c and I don't think it's going in the right direction, as it's trying to think about results as if they are arguments, when the SILFunctionConventions use a type distinction between SILParameterInfo and SILResultInfo to help avoid confusion there.
kavon
force-pushed
the
opaque-values/fixes-3
branch
from
a992f6e to
861c6e7
Compare
|
@swift-ci smoke test |
resolves rdar://163071245
kavon
force-pushed
the
opaque-values/fixes-3
branch
from
861c6e7 to
19bd65c
Compare
|
@swift-ci smoke test |
2 participants
Now you can build and run programs that use property wrappers with
-enable-sil-opaque-values.resolves rdar://163071245