[update-checkout] refactor shell invocations #85056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charles-zablit
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
charles-zablit
requested review from
adrian-prantl
and removed request for
etcwilde,
justice-adams-apple and
shahmishal
|
@swift-ci please smoke test |
charles-zablit
force-pushed
the
charles-zablit/update-checkout/refactor-shell-invocations
branch
from
9525875 to
f094494
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test windows |
adrian-prantl
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch refactors the shell invocations in
update-checkoutby removing theshellmodule dependency. Theshellmodule is used by various modules, most notably thebuild-script. Extracting the methods allows us a better control over the Exception we throw. Furthermore,shell.runwas only used inupdate-checkout.This refactor also simplifies the use of
subprocess, which should help us fix some of the inconsistencies we are seeing on Windows.