[IDE] A couple of fixes for @abi
#85062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
requested review from
Xazax-hun,
bnbarham,
egorzhdan,
fahadnayyar,
hborla,
j-hui,
rintaro,
slavapestov,
susmonteiro,
tshortli,
xedin and
zoecarver
as code owners
|
@swift-ci please SourceKit stress test |
hamishknight
force-pushed
the
not-the-bees
branch
from
9a638be to
0369014
Compare
hamishknight
requested review from
beccadax,
ian-twilightcoder and
xymus
as code owners
beccadax
approved these changes
Oct 22, 2025
| return true; | ||
|
|
||
| // We only care about API for documentation purposes. | ||
| if (!ABIRoleInfo(D).providesAPI()) |
bnbarham
approved these changes
Oct 22, 2025
Comment on lines
-193
to
+201
| DWARFMangling = true; | ||
| this->DWARFMangling = true; |
There was a problem hiding this comment.
😨 wasn't breaking any tests?
There was a problem hiding this comment.
Apparently not, mangleTypeForDebugger also sets this to true though, which seems to be the main client that relies on it. I somewhat suspect we could remove this parameter from the constructor
Make sure we avoid adding these to the entity stack entirely, which avoids hitting the assertion that a top-level entity isn't encountered with a non-empty stack.
Turns out this constructor was never actually setting this bit. `mangleTypeForDebugger` also sets this to `true`, so it doesn't seem like this caused issues in practice, but let's actually set it. This parameter seems like it could be removed at this point, but I'll leave that for a follow-up.
Rather than setting the USR-specific bits for each USR entrypoint into the mangler just expose a convenience constructor for USR generation that sets them.
This was always set to `true` except for USR mangling, where we already have it set to `false` for IDE USRs. The other clients were: - AutoDiff, which is just using the resulting string as a dictionary key, so don't seem to have any preference. - The ClangImporter, which always overrides `@_originallyDefinedIn` anyway.
This is used by other things that don't necessarily want an IDE USR.
For semantic functionality the API decl is the more useful thing to mangle, and redeclaration checking ensures we can't end up with conflicts. This ensures we're able to perform a name lookup for the decl based on its USR without having to maintain a separate lookup table for ABI names.
hamishknight
force-pushed
the
not-the-bees
branch
from
0369014 to
c7e9809
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abideclaration in SourceKit'sAnnotatingPrinter@abideclaration when mangling USRs for semantic functionality since we need to be able to perform name lookup using the mangled name to retrieve the original decl. It also seems like it makes more sense in general for USRs to only be concerned about the API of a given declaration since for semantic functionality we don't care about ABI.Resolves #85030