Skip to content

Conversation

@owenv
Copy link
Contributor

@owenv owenv commented Oct 23, 2025

This will be a sourcekit-lsp dependency starting with swiftlang/sourcekit-lsp#2324, a SwiftPM dependency starting with swiftlang/swift-package-manager#9129, and a swift-build dependency starting with swiftlang/swift-build#782. Update the windows build script accordingly

@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 2e16a23 to 2857499 Compare October 23, 2025 16:06
@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

2 similar comments
@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

@owenv
Copy link
Contributor Author

owenv commented Oct 23, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

-SwiftSDK $SDKROOT `
-BuildTargets default `
-Defines @{
BUILD_SHARED_LIBS = "NO";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a single use library? i.e. does only one product use the library? If not, we should consider the shared version with numbers on the size impact - that is verify that static linking is smaller than the dynamic linking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to get linked into at least two executables, so I will probably end up flipping it to a shared library but I haven't tested it yet

@owenv owenv force-pushed the owenv/tools-protocols-windows branch from 2857499 to 57a58c7 Compare October 24, 2025 16:34
@owenv
Copy link
Contributor Author

owenv commented Oct 24, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

1 similar comment
@owenv
Copy link
Contributor Author

owenv commented Oct 24, 2025

swiftlang/sourcekit-lsp#2324
@swift-ci please smoke test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants