-
Notifications
You must be signed in to change notification settings - Fork 10.6k
build.ps1: add swift-tools-protocols #85078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
swiftlang/sourcekit-lsp#2324 |
2e16a23 to
2857499
Compare
|
swiftlang/sourcekit-lsp#2324 |
2 similar comments
|
swiftlang/sourcekit-lsp#2324 |
|
swiftlang/sourcekit-lsp#2324 |
| -SwiftSDK $SDKROOT ` | ||
| -BuildTargets default ` | ||
| -Defines @{ | ||
| BUILD_SHARED_LIBS = "NO"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a single use library? i.e. does only one product use the library? If not, we should consider the shared version with numbers on the size impact - that is verify that static linking is smaller than the dynamic linking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's going to get linked into at least two executables, so I will probably end up flipping it to a shared library but I haven't tested it yet
2857499 to
57a58c7
Compare
|
swiftlang/sourcekit-lsp#2324 |
1 similar comment
|
swiftlang/sourcekit-lsp#2324 |
This will be a sourcekit-lsp dependency starting with swiftlang/sourcekit-lsp#2324, a SwiftPM dependency starting with swiftlang/swift-package-manager#9129, and a swift-build dependency starting with swiftlang/swift-build#782. Update the windows build script accordingly