Fix ASAN stack-use-after-scope errors Basic/TaskQueueTest.cpp
#85080
Conversation
The issue was that in three tests, the `Args` arrays were being declared inside for loops. When `TQ.addTask()` was called, it stored a pointer to the `Args` array. As the `Args` array was declared in the loop, it would go out of scope at the end of each iteration whilst `TaskQueue` held a pointer to it.
|
@swift-ci Please test |
|
preset=asan |
1 similar comment
|
preset=asan |
|
@swift-ci Please test macOS platform |
|
preset=asan |
|
The test with preset=asan has timed out twice now. Either there is something wrong with the configuration of the bot "swift-PR-osx-preset" that makes it fail with the ASAN preset, or it is an error that happens with ASAN enabled. I am inclined to merge and let the regular ASAN bot find whether it is the second case. |
|
@KushalP For the future, you can grab the preset from the logs of a job. For example, https://ci.swift.org/job/oss-swift-incremental-ASAN-RA-macos is using |
4 participants
The issue was that in three tests, the
Argsarrays were being declared inside for loops.When
TQ.addTask()was called, it stored a pointer to theArgsarray. As theArgsarray was declared in the loop, it would go out of scope at the end of each iteration whilstTaskQueueheld a pointer to it.