Skip to content

Conversation

@a7medev
Copy link
Member

@a7medev a7medev commented Oct 26, 2025

  1. Add fix-its for unexpected or expected comma in @differentiable, @derivative, and @transpose arguments.
  2. Assert on fix-its for unexpected/expected comma in tests.

@a7medev
Copy link
Member Author

a7medev commented Oct 26, 2025

@swift-ci please test

@a7medev a7medev changed the title Add fix-its for unexpected/expected comma for auto differentiation attributes [Diagnostics] Add fix-its for unexpected/expected comma for auto differentiation attributes Oct 26, 2025
@a7medev a7medev force-pushed the autodiff-comma-fix-its branch from db9c85b to d0c2d8b Compare October 26, 2025 20:47
@a7medev
Copy link
Member Author

a7medev commented Oct 26, 2025

@swift-ci please test

@a7medev a7medev changed the title [Diagnostics] Add fix-its for unexpected/expected comma for auto differentiation attributes [Diagnostics] Add missing fix-its for unexpected/expected comma in attribute arguments Oct 26, 2025
Copy link
Contributor

@asl asl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@a7medev
Copy link
Member Author

a7medev commented Oct 27, 2025

@asl Can you please merge this PR since CI is green?

@hamishknight hamishknight merged commit b5627c9 into swiftlang:main Oct 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants