Skip to content

Fix crash when accessing span of empty InlineArray #85268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2025
Merged

Fix crash when accessing span of empty InlineArray #85268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7005c2
fix(InlineArray): avoid crash when creating span for empty arrays
jairajput Nov 2, 2025
1b2ac42
[test] change to a simpler syntax
glessard Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions stdlib/public/core/InlineArray.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,10 @@ extension InlineArray where Element: ~Copyable {
@lifetime(borrow self)
@_transparent
borrowing get {
guard count > 0 else {
let span = Span<Element>()
return unsafe _overrideLifetime(span, borrowing: self)
}
let span = unsafe Span(_unsafeStart: _protectedAddress, count: count)
return unsafe _overrideLifetime(span, borrowing: self)
}
Expand All @@ -598,6 +602,10 @@ extension InlineArray where Element: ~Copyable {
@lifetime(&self)
@_transparent
mutating get {
guard count > 0 else {
let span = MutableSpan<Element>()
return unsafe _overrideLifetime(span, mutating: &self)
}
let span = unsafe MutableSpan(
_unsafeStart: _protectedMutableAddress,
count: count
Expand Down
21 changes: 21 additions & 0 deletions test/stdlib/Span/InlineSpanProperties.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ suite.test("InlineArray.span property (String)")
}
}

suite.test("InlineArray.span property (empty, aligned)")
.require(.stdlib_6_2).code {
guard #available(SwiftStdlib 6.2, *) else { return }

let empty: InlineArray<0, Padded> = []
let span = empty.span
expectTrue(span.isEmpty)
expectEqual(span.count, 0)
}

suite.test("InlineArray.mutableSpan property")
.require(.stdlib_6_2).code
{
Expand Down Expand Up @@ -146,3 +156,14 @@ suite.test("InlineArray.mutableSpan property (String)")
let s = span[3]
expectTrue(s._isIdentical(to: v[3]))
}

suite.test("InlineArray.mutableSpan property (empty, aligned)")
.require(.stdlib_6_2).code
{
guard #available(SwiftStdlib 6.2, *) else { return }

var empty: InlineArray<0, Padded> = []
var span = empty.mutableSpan
expectTrue(span.isEmpty)
expectEqual(span.count, 0)
}