[update-checkout] refactor to use pathlib.Path instead of os.path #85277
Conversation
charles-zablit
requested review from
etcwilde,
justice-adams-apple and
shahmishal
as code owners
charles-zablit
force-pushed
the
charles-zablit/update-checkout/add-tests
branch
2 times, most recently
from
d7a52fd to
4f72ffa
Compare
charles-zablit
changed the title
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
charles-zablit
force-pushed
the
charles-zablit/update-checkout/add-tests
branch
from
4f72ffa to
9307640
Compare
|
@swift-ci please smoke test |
|
|
||
| def call_quietly(*args, **kwargs): | ||
| kwargs["stderr"] = subprocess.STDOUT | ||
| kwargs["encoding"] = "utf-8" |
There was a problem hiding this comment.
why is this part of "delete unused test"?
utils/update_checkout/README.md
Outdated
| ./swift/utils/update-checkout --clone --scheme release/6.2 | ||
| ``` | ||
|
|
||
| The command above will use `HTTP` to clone the repositories. Use `--clone-with-ssh` to clone with `SSH` instead: |
|
Individually these all look good, but this should have really been three separate PRs. |
|
Are you sure you want to use Pathlib? From my experience it is really slow compared to os.path. I did not have any problems with os.path either. |
charles-zablit
force-pushed
the
charles-zablit/update-checkout/add-tests
branch
from
9307640 to
1d9d003
Compare
charles-zablit
changed the title
I ended up splitting the changes into separate PRs instead to simplify failure tracking (if we see failures in CI). This PR is now only converting |
The overall goal is to improve Regarding the slowness concerns, |
|
@swift-ci please smoke test |
|
@swift-ci please test windows |
1 similar comment
|
@swift-ci please test windows |
3 participants
Refactor the uses of
os.pathinupdate-checkoutby thepathlib.Pathclass to avoid string manipulation. This is part of an effort to improve the reliability of `update-checkout on Windows.