[Sema] Fix crash when diagnosing ambiguous trailing closure inits #85406
Conversation
Fixes swiftlang#85376. This fixes a compiler crash that occurred when diagnosing an ambiguous call using trailing closure syntax, where one of the candidates was a function or initializer with no parameters.
naveen-seth
requested review from
hborla,
slavapestov and
xedin
as code owners
|
Thank you @naveen-seth! I will take a look tomorrow! |
lib/Sema/CSDiagnostics.cpp
Outdated
| return false; | ||
|
|
||
| const ParameterList *paramList = callee->getParameters(); | ||
| if (paramList->getArray().empty()) |
There was a problem hiding this comment.
Let's change this condition to (!paramList || paramList->size() == 0) and paramList->getArray().back() could be changed to paramList->back() while we are here.
There was a problem hiding this comment.
Done. Thank you for reviewing!
|
@swift-ci please smoke test |
|
@naveen-seth Looks like you need to mark |
|
@swift-ci please smoke test |
Ah, I see! For future reference, should I have just extended the test in And in general, should all regression checks that guard against crashes be added under |
|
@naveen-seth Yes, you can move your test case to the same place and use |
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
2 participants
This fixes a compiler crash that occurred when diagnosing an ambiguous call using trailing closure syntax, where one of the candidates was a function or initializer with no parameters.
The crash was caused by calling
.back()on the candidate's empty parameter list, which is now guarded against.Resolves #85364, resolves #85378.