[AST/Serialization] A few fixes for nonisolated(nonsending) handling
#85418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itions Printing shouldn't rely on parameter declaration bit because it only works in cases when there is an explicit `nonisolated(nonsending)` modifier on the type. Always print `nonisolated(nonsending)` before `sending`, `@escaping` and other declaration attributes/modifiers to avoid parsing issues. Resolves: rdar://164267736
xedin
requested review from
hborla,
ktoso,
slavapestov,
tshortli and
xymus
as code owners
Contributor
Author
|
@swift-ci please test |
hamishknight
approved these changes
Nov 11, 2025
This was used primarily by the printer and doesn't work when `nonisolated(nonsending)` is inferred, so let's remove it.
xedin
force-pushed
the
rdar-164267736
branch
from
4c8f943 to
4780581
Compare
Contributor
Author
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix printing of
nonisolated(nonsending)in parameter type positionsPrinting shouldn't rely on parameter declaration bit because it only
works in cases when there is an explicit
nonisolated(nonsending)modifier on the type.
Always print
nonisolated(nonsending)beforesending,@escapingand other declaration attributes/modifiers to avoid parsing issues.
Make sure that
nonisolated(nonsending)works together with@autoclosureRemove
isCallerIsolatedbit fromParamDeclas obsolete.Resolves: rdar://164267736