[ClangImporter] Do not import enum when already imported via DeclContext #85424
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-hui
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder and
susmonteiro
as code owners
Contributor
Author
|
@swift-ci please test |
hnrklssn
reviewed
Nov 11, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
| if (!HadForwardDeclaration) { | ||
| auto it = ImportedDecls.try_emplace({Canon, version}, Result); | ||
| if (!it.second && Result != it.first->second) { | ||
| ABORT([&](auto &out) { |
Member
There was a problem hiding this comment.
nice, didn't know about this macro
hnrklssn
reviewed
Nov 11, 2025
lib/ClangImporter/ImportDecl.cpp
Outdated
| Canon->getSourceRange().print(out, Instance->getSourceManager()); | ||
| } | ||
| out << "\nImported as Swift Decl:\n"; | ||
| Result->dump(out, 4); |
Member
There was a problem hiding this comment.
there's an indentation parameter to dump?? is that true for all of them or just decls?
Contributor
Author
There was a problem hiding this comment.
Appears to be available for all swift::Decls
hnrklssn
reviewed
Nov 11, 2025
j-hui
force-pushed
the
check-cache-4-enumz
branch
from
6c51588 to
b1aa927
Compare
Contributor
Author
|
@swift-ci please test |
Member
It works 🥳 |
j-hui
force-pushed
the
check-cache-4-enumz
branch
from
b1aa927 to
005acc4
Compare
Contributor
Author
|
@swift-ci please test |
j-hui
force-pushed
the
check-cache-4-enumz
branch
from
005acc4 to
2092b20
Compare
Contributor
Author
|
@swift-ci please test |
Xazax-hun
approved these changes
Nov 13, 2025
Member
|
What was the change after force push? |
Contributor
Author
|
The change was making |
Contributor
|
@hnrklssn the GitHub UI doesn't make it very obvious, but you can click on the "force-pushed" label and that will show you the diff 😉 |
egorzhdan
approved these changes
Nov 13, 2025
Before we import an enum, we import its DeclContext. If that DeclContext
gets resolved to a struct that contains that field of that enum type,
e.g.:
typedef CF_OPTIONS(uint32_t, MyFlags) {
...
} CF_SWIFT_NAME(MyCtx.Flags);
struct MyStruct {
MyFlags flags;
...
} CF_SWIFT_NAME(MyCtx);
We end up with a cycle, i.e., MyFlags -> MyCtx -> MyStruct -> MyFlags.
Existing cycle-breaking mechanisms seem to prevent this from looping
infinitely, but it leads to us importing two copies of the enum, which
can cause errors later during CodeGen.
This patch breaks the cycle by checking the cache again.
N.B. as of this commit, the circular-import-as-member.swift test doesn't
actually fail *without* the fix, because ClangImporter is quite
lenient about importing the same clang::Decl multiple times. An earlier
attempt at this patch ABORT()'d the compiler as soon as a duplicate is
detected, but that led to more isseus beyond the scope of this patch.
rdar://162317760
j-hui
force-pushed
the
check-cache-4-enumz
branch
from
2092b20 to
5cca1a6
Compare
Contributor
Author
|
@swift-ci please test |
Member
You can also click the "Compare" button to the right ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we try to import this in ObjC interop mode:
ClangImporter tries to import
MyCtx/MyStructbefore it importsMyFlags(viaimportDeclContextOf()), which in turn tries to importMyFlagsagain due to theflagsfield. The existing cycle-breaking mechanism prevents us from looping infinitely, but leads us to import two copies of the SwiftEnumDecl, which can cause errors later during CodeGen.This patch adds an assertion to catch such issues earlier, and breaks the cycle by checking the cache again.This patch no longer does so because that caused issues beyond the scope of this patch.rdar://162317760