Don't abort on Linux if withLockIfAvailable() is called recursively.
#85448
+1
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On all platforms except Linux, calling `withLockIfAvailable()` recursively just returns `nil`. However, our Linux implementation chooses to abort the process instead. We don't need this inconsistent/destructive behaviour and can just return `nil` as we do elsewhere.
grynspan
added
concurrency
Contributor
Author
|
@swift-ci test |
mikeash
approved these changes
Nov 11, 2025
jamieQ
reviewed
Nov 11, 2025
Azoy
approved these changes
Nov 12, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On all platforms except Linux, calling
withLockIfAvailable()recursively just returnsnil. However, our Linux implementation chooses to abort the process instead. We don't need this inconsistent/destructive behaviour and can just returnnilas we do elsewhere.