Basic: Use getrusage() to read memory usage #85452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS 26, malloc_zone_statistics() always returns a malloc_statistics_t with the max_size_in_use field set to zero. This was an intentional change, so let's remove calls to this API. Instead, use the proc_pid_rusage() API and return the ri_lifetime_max_phys_footprint field of rusage_info_v4. Finally, remove the llvm::sys::Process::GetMallocUsage() call on other platforms altogether. It returns the current value and not the max value, so its misleading.
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS 26, malloc_zone_statistics() always returns a malloc_statistics_t with the max_size_in_use field set to zero. This was an intentional change, so let's remove calls to this API.
Instead, use the proc_pid_rusage() API and return the ri_lifetime_max_phys_footprint field of rusage_info_v4.
Finally, remove the llvm::sys::Process::GetMallocUsage() call on other platforms altogether. It returns the current value and not the max value, so its misleading.