AST: Rename mapTypeIntoContext() => mapTypeIntoEnvironment(), mapTypeOutOfContext() => mapTypeOutOfEnvironment() #85459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
requested review from
AnthonyLatsis,
Xazax-hun,
adrian-prantl,
asl,
beccadax,
bnbarham,
eeckstein,
egorzhdan,
hamishknight,
hborla,
ian-twilightcoder,
j-hui,
jckarter,
kavon,
ktoso,
rintaro,
rjmccall,
susmonteiro,
tshortli,
xedin and
xymus
as code owners
Contributor
Author
|
swiftlang/llvm-project#11809 |
xedin
approved these changes
Nov 12, 2025
…OutOfContext() => mapTypeOutOfEnvironment()
…nment(), mapReplacementTypesOutOfContext() => subs.mapReplacementTypesOutOfEnvironment()
jamieQ
reviewed
Nov 12, 2025
| if (auto *AFD = TheFunction.dyn_cast<AbstractFunctionDecl *>()) { | ||
| if (auto *FD = dyn_cast<FuncDecl>(AFD)) | ||
| return FD->mapTypeIntoContext(FD->getResultInterfaceType()); | ||
| return FD->mapTypeIntoEnvironment(FD->getResultInterfaceType()); |
Contributor
There was a problem hiding this comment.
@slavapestov is the generics book going to need another update? 😄 – but more seriously, what's the rename motivation? is 'context' too overloaded?
Contributor
Author
There was a problem hiding this comment.
Yes, I'll upload a new version of chapters/archetypes.tex next time around. The motivation for the rename is that "context" is too overloaded, yeah. See the PR description
Contributor
There was a problem hiding this comment.
ah, my bad – i think i saw the PR before it had a description 🙈
slavapestov
force-pushed
the
rename-generic-environment-operations
branch
from
146b205 to
64f2d1a
Compare
Contributor
Author
|
swiftlang/llvm-project#11809 |
AnthonyLatsis
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing being mapped into and out of is
GenericEnvironment, and notGenericContext(the latter exists, but it's aDeclContextsubclass that's mostly internal to a few things in the AST). Let's rename these operations since "context" is already a highly overloaded term, and it's clearer if people talk about "mapping types into a generic environment", etc, since then we know exactly what is being referred to.