Revert "Sema: Prefer the submodule import for access-levels diagnostics" #85468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
egorzhdan,
hborla,
j-hui,
slavapestov,
susmonteiro and
xedin
as code owners
Member
Author
|
@swift-ci please smoke test |
Contributor
|
When reverting a PR because it introduced a regression, please add a test case demonstrating the problem in a separate commit, so that we can be sure the regression is fixed when the PR is re-applied. |
hnrklssn
force-pushed
the
revert-dedup-clang-module-imports
branch
from
d051f18 to
ed6d2de
Compare
Member
Author
Thanks, I wasn't aware of this practice, but it makes a lot of sense. Added 0fce8a3. After reverting it compiles fine. |
Member
Author
|
@swift-ci please smoke test |
This test case compiled fine before da96079 and the subsequent swiftlang#84828, but now errors. The next commit will revert those changes.
This reverts commit ca8792c. Revert "[ImportResolution] Gracefully handle importing broken clang module" This reverts commit edb48df. Revert "[ImportResolution] Don't deduplicate scoped imports" This reverts commit da96079. Revert "[ImportResolution] Deduplicate top-level clang modules from import list" This reverts commit 0ea5677. Reverting due to namelookup errors. rdar://164588082
hnrklssn
force-pushed
the
revert-dedup-clang-module-imports
branch
from
ed6d2de to
ba7b9b0
Compare
Member
Author
|
added pragma once to test case |
Member
Author
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ca8792c.
Revert "[ImportResolution] Gracefully handle importing broken clang module"
This reverts commit edb48df.
Revert "[ImportResolution] Don't deduplicate scoped imports"
This reverts commit da96079.
Revert "[ImportResolution] Deduplicate top-level clang modules from import list"
This reverts commit 0ea5677.
Reverting due to namelookup errors.
rdar://164588082