[DiagnosticVerifier] improve output for expansions in clang attributes #85528
+114
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
susmonteiro and
tshortli
as code owners
Member
Author
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
diag-verify-fixes
branch
from
3ed143c to
26fb12b
Compare
Member
Author
|
Updated [DiagnosticVerifier] don't repeat diagnostics in other files and [DiagnosticVerifier] ensure expansion ancestors are populated with their respective test failures |
Member
Author
|
@swift-ci please smoke test |
Open
...-verify-additional-file It's not expected that users add macro expansion buffer names to -verify-additional-file. The recommended approach is to add the actual source file that the macro was expanded in, and use expected-expansion.
This won't affect diagnostic printing, as the diagnostic engine checks the GeneratedSourceInfoKind and stops expanding if it's an AttributeFromClang kind. This helps the diagnostic verifier expand to the original location in source code however.
This makes it more explicit and consistent, which are good properties for test output. It makes it easier both for humans and update-verify-tests to see what exactly is going on. This does not affect how diagnostics are displayed to users normally.
`verifyUnknown()` and `verifyUnrelated()` would not remove the diagnostics after reporting their errors, leading to the same diagnostics then being emitted a second time. This removes them from the list after emitting them, just like `verifyFile()` does.
Simply GSI->ancestors is not enough if the ancestors list has not been populated yet. Ensure this is done by calling getAncestors.
hnrklssn
force-pushed
the
diag-verify-fixes
branch
from
26fb12b to
69f6f47
Compare
Member
Author
|
Updated each commit with |
Member
Author
|
@swift-ci please smoke test |
Member
Author
|
@swift-ci please smoke test windows platform |
1 similar comment
Member
Author
|
@swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
test/Frontend/DiagnosticVerifier/clang-attribute.swift, and then makes a series of improvements to the output.I recommend reviewing commit by commit.