Skip to content

Conversation

@aidan-hall
Copy link
Contributor

@aidan-hall aidan-hall commented Nov 17, 2025

  • Explanation: Disable the PackSpecialization pass in the FunctionPass pipeline, and mark the pack_specialization.swift test file, which relies on the pass, as XFAIL
  • Scope: This change has minimal impact, since it is just a 2-line change to temporarily disable an optimization and an associated test. It is highly important, since the current PackSpecialization pass causes compiler crashes when building certain projects (see issue).
  • Issues: rdar://164515160
  • Original PRs: SILOptimizer: Disable PackSpecialization pass until it has been properly fixed. #85491
  • Risk: Lost potential performance gains from the pass.
  • Testing: Unit tests (see below).
  • Reviewers: @eeckstein

@aidan-hall aidan-hall changed the base branch from main to release/6.3 November 17, 2025 18:08
@aidan-hall aidan-hall requested review from eeckstein and removed request for eeckstein November 17, 2025 18:09
@aidan-hall aidan-hall self-assigned this Nov 17, 2025
@aidan-hall
Copy link
Contributor Author

@swift-ci smoke test

@aidan-hall
Copy link
Contributor Author

@swift-ci test

@aidan-hall aidan-hall marked this pull request as ready for review November 18, 2025 10:51
@aidan-hall aidan-hall requested a review from a team as a code owner November 18, 2025 10:51
@tbkka
Copy link
Contributor

tbkka commented Nov 18, 2025

Thank you!

@aidan-hall aidan-hall merged commit fd1e5cd into swiftlang:release/6.3 Nov 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants