Revert "[Caching][NFC] Using llvm::cas::CASConfiguration" #85547
+23
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4f05903. The change is actually not NFC since previously, there is a cache in the CompilerInvocation that prevents the same CAS from the same CASOptions from being initialized multiple times, which was relied upon when running inside sub invocation. When switching to a non-caching simple CASOption types, it causes every single sub instance will create its own CAS, and it can consume too many file descriptors and causing errors during dependency scanning. rdar://164903080
cachemeifyoucan
requested review from
DougGregor,
Xazax-hun,
artemcm,
beccadax,
egorzhdan,
hborla,
ian-twilightcoder,
j-hui,
slavapestov,
susmonteiro,
tshortli and
xedin
as code owners
Contributor
Author
|
Please test with following PR: @swift-ci please smoke test |
Contributor
Author
|
Please test with following PR: @swift-ci please smoke test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4f05903. The change is actually not NFC since previously, there is a cache in the CompilerInvocation that prevents the same CAS from the same CASOptions from being initialized multiple times, which was relied upon when running inside sub invocation. When switching to a non-caching simple CASOption types, it causes every single sub instance will create its own CAS, and it can consume too many file descriptors and causing errors during dependency scanning.
rdar://164903080