CustomAvailability: synthesized dynamic availability checking function should be private #85549
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
private-predicate-check
branch
from
dcd7c04 to
3609030
Compare
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
private-predicate-check
branch
from
3609030 to
1d915ca
Compare
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
private-predicate-check
branch
2 times, most recently
from
604d160 to
496f1d1
Compare
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
private-predicate-check
branch
from
496f1d1 to
0eeaa96
Compare
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
force-pushed
the
private-predicate-check
branch
from
0eeaa96 to
59c08d3
Compare
Contributor
Author
|
@swift-ci please smoke test |
…n should be private When compiling a Swift module in incremental mode, each Swift source file is compiled into an object file and we use linker to link them together. Because the predicate function for checking dynamic feature availability is eagerly synthesized per compilation unit, the linker will complain about duplicated symbols for them. Setting their visibility as private ensures that linker doesn't see them, thus addressing the linker errors. One workaround for this problem is to enable WMO. rdar://164971313
nkcsgexi
force-pushed
the
private-predicate-check
branch
from
59c08d3 to
d144524
Compare
nkcsgexi
changed the title
Contributor
Author
|
@swift-ci please smoke test |
nkcsgexi
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
jckarter,
susmonteiro and
tshortli
as code owners
slavapestov
approved these changes
Nov 18, 2025
DougGregor
reviewed
Nov 18, 2025
| funcDecl->setBodySynthesizer(synthesizeAvailabilityDomainPredicateBody, | ||
| (void *)var); | ||
| funcDecl->setAccess(AccessLevel::Internal); | ||
| funcDecl->setAccess(AccessLevel::Private); |
Member
There was a problem hiding this comment.
Why private rather than marking them as @export(implementation), which allows the linker to merge the different copies in different translation units?
Contributor
Author
There was a problem hiding this comment.
Do we worry about deserialization issues trigged by the function body of this synthesized function when marked as @export(implementation)? Previously, we have been hitting a module deserialization error (e.g.rdar://164410957).
Contributor
Author
|
@swift-ci please smoke test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling a Swift module in incremental mode, each Swift source file is compiled into an object file and we use linker to link them together. Because the predicate function for checking dynamic feature availability is eagerly synthesized per compilation unit, the linker will complain about duplicated symbols for them. Setting their visibility as private ensures that linker doesn't see them, thus addressing the linker errors.
One workaround for this problem is to enable WMO.
rdar://164971313