Fix the issue that struct _GUID isn't found on Windows #85550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@swift-ci please test |
hjyamauchi
requested review from
Xazax-hun,
beccadax,
egorzhdan,
ian-twilightcoder,
j-hui,
susmonteiro and
xymus
as code owners
Member
|
Can you please improve the commit message? This feels pretty slim and doesn't give much context. |
Contributor
Author
Done |
Contributor
Author
|
@swift-ci please test |
compnerd
reviewed
Nov 18, 2025
Contributor
Author
|
@swift-ci please test windows platform |
1 similar comment
Contributor
Author
|
@swift-ci please test windows platform |
Predefined declarations (like _GUID) are special forward declarations inserted by Clang and aren't serialized into the pcm and their definition pointers aren't retained across serialization and deserialization, which causes this type not found error. Avoid putting non-defining predefined declarations into the swift lookup table when their definitions exist in the same module so that the definitions will be associated with the base name and avoid this error.
Contributor
Author
|
@swift-ci please test |
Contributor
Author
|
@swift-ci please test windows platform |
compnerd
approved these changes
Nov 20, 2025
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Thank you! This reads much better.
Contributor
Author
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.