IRGen: Remove unsafe usage of static variable #85560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Nov 18, 2025
slavapestov
force-pushed
the
fix-ridiculous-irgen-thing
branch
from
fba174a to
b2c9b4a
Compare
As the above comments imply, when isTypeKind() returns true, then getType() should return a valid Type. This wasn't true with DifferentiabilityWitness.
We cannot use 'static' linkage for something that points into the ASTContext, because there might be more than one ASTContext in a single process. Also, fix the spelling mistake in a related function name.
slavapestov
force-pushed
the
fix-ridiculous-irgen-thing
branch
from
b2c9b4a to
ca0f310
Compare
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot use 'static' linkage for something that points into the ASTContext, because there might be more than one ASTContext in a single process.
Also, fix the spelling mistake in a related function name.
Finally, LinkEntity::Kind::DifferentiabilityWitness was in the wrong place. It's not a type kind. Move it to avoid UB when calling
isTypeKind().