[6.3][Caching] Fix multi-threaded WMO with MCCAS #85563
Open
+158
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cachemeifyoucan
commented
Nov 18, 2025
cachemeifyoucan
commented
- Explanation: MCCAS wasn't setup correctly when using parallel WMO. Make sure the CAS ObjectStore and ResultCallbacks are passed to LLVM backend when using parallel WMO.
- Scope: This affects compilation caching and using MCCAS backend only. Fixes a crash that previously happens.
- Issues: rdar://164409895
- Original PRs: [Caching] Fix multi-threaded WMO with MCCAS #85499
- Risk: Low.
- Testing: Unit test added.
- Reviewers: @artemcm
MCCAS wasn't setup correctly when using parallel WMO. Make sure the CAS ObjectStore and ResultCallbacks are passed to LLVM backend when using parallel WMO. rdar://164409895 (cherry picked from commit b1d669b)
cachemeifyoucan
changed the title
Contributor
Author
|
@swift-ci please test |
nkcsgexi
approved these changes
Nov 18, 2025
Contributor
Author
|
@swift-ci please test windows platform |
Contributor
Author
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.