Skip to content

Follow up: Availability of Set thread base priority when running escalated Tasks #85610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2025
Merged

Follow up: Availability of Set thread base priority when running escalated Tasks #85610

merged 1 commit into from
Nov 20, 2025
+7 −7

Conversation

@ktoso
Copy link
Contributor

@ktoso ktoso commented Nov 20, 2025 •
edited
Loading

Follow up to adjust availability of APIs

Marking those 9998, following an established pattern:

// These are deliberately not the standard 9999, as we don't want to hit the
// special case where it's always available, and we don't want this check to be
// rewritten in any find/replace operations.
if #available(macOS 9998, iOS 9998, tvOS 9998, watchOS 9998, *) {

@ktoso ktoso force-pushed the wip-adjust-availability branch from 9fa3bf5 to 5f83c54 Compare November 20, 2025 02:15
@ktoso
Copy link
Contributor Author

ktoso commented Nov 20, 2025

@swift-ci please smoke test

@ktoso ktoso enabled auto-merge (squash) November 20, 2025 02:17
@ktoso
Copy link
Contributor Author

ktoso commented Nov 20, 2025

@swift-ci please smoke test Windows

2 similar comments
@Bryce-MW
Copy link
Contributor

Bryce-MW commented Nov 20, 2025

@swift-ci please smoke test Windows

@ktoso
Copy link
Contributor Author

ktoso commented Nov 20, 2025

@swift-ci please smoke test Windows

@rjmansfield rjmansfield disabled auto-merge November 20, 2025 21:13
@rjmansfield rjmansfield merged commit 2334140 into swiftlang:main Nov 20, 2025
2 of 3 checks passed
@ktoso ktoso deleted the wip-adjust-availability branch November 20, 2025 21:14
dnadoba
dnadoba reviewed Nov 20, 2025
View reviewed changes
include/swift/Runtime/DispatchShims.h
if (__builtin_available(macOS 9998, iOS 9998, tvOS 9998, watchOS 9998, *)) {
return dispatch_thread_override_self_with_base(override_qos, base_qos);
} else if (__builtin_available(macOS 13.0, iOS 16.0, tvOS 16.0, watchOS 9.0, *)) {
} else if (__builtin_available(macOS 9998, iOS 9998, tvOS 9998, watchOS 9998, *)) {
Copy link
Contributor

@dnadoba dnadoba Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ktoso why has this been changed? Shouldn't this stay with macOS 13 etc.?
Otherwise this doesn't make a lot of sense as this is already covered by the condition above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnadoba dnadoba dnadoba left review comments

@Bryce-MW Bryce-MW Bryce-MW approved these changes

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

@compnerd compnerd Awaiting requested review from compnerd compnerd is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ktoso @Bryce-MW @dnadoba @rjmansfield