Skip to content

[stdlib] Dictionary/Set enhancements #9030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2017
Merged

[stdlib] Dictionary/Set enhancements #9030

merged 1 commit into from
Apr 29, 2017

Conversation

@natecook1000
Copy link
Member

This PR implements the changes approved in SE-154 and SE-165:

  • Custom Keys and Values collections for Dictionary
  • Two sequence-based Dictionary initializers
  • Merging methods for Dictionary
  • Capacity checking and reserving for Dictionary and Set
  • Type-specific filter(_:) methods for Dictionary and Set
  • A mapValues(_:) method for Dictionary
  • A Dictionary(grouping:by:) initializer

@natecook1000
[stdlib] Dictionary/Set enhancements
e232888 
A variety of enhancements from SE-154 and SE-165:

- Custom Keys and Values collections for Dictionary
- Two sequence-based Dictionary initializers
- Merging methods for Dictionary
- Capacity checking and reserving for Dictionary and Set
- Type-specific filter(_:) methods for Dictionary and Set
- A mapValues(_:) method for Dictionary
- A grouping Dictionary initializer
@natecook1000
Copy link
Member Author

@swift-ci Please smoke test

@natecook1000
Copy link
Member Author

🤔 test/Constraints/bridging.swift is segfaulting for me locally, too. @DougGregor are you the right person to cc on this?

@DougGregor
Copy link
Member

Yeah, I guess that'd be me. Just pull your changes and see what goes wrong with that test? Do you have a backtrace handy?

@natecook1000
Copy link
Member Author

I compile in Release mode so I'm not sure this has everything you need, but: https://gist.github.com/natecook1000/31ca8bf769230a6c9da25aa08606c24f

@DougGregor
Copy link
Member

Oooh, the diagnostics machinery is doing a substitution that SubstitutionMap can't handle... but probably should. I'm looking at it now.

@DougGregor
Copy link
Member

@natecook1000 , #9106 fixes the crash. You should be good to go once that gets merged.

@DougGregor
Copy link
Member

Of course, I screwed up #9106. I'll kick off a retest of this PR once I get my act together.

@DougGregor
Copy link
Member

@swift-ci Please smoke test

@DougGregor
Copy link
Member

@swift-ci please clean smoke test Linux

1 similar comment
@DougGregor
Copy link
Member

@swift-ci please clean smoke test Linux

@DougGregor DougGregor merged commit e90b7f9 into swiftlang:master Apr 29, 2017
@DougGregor
Copy link
Member

@natecook1000 could you open a PR with a ChangeLog entry for this?

@aschwaighofer
Copy link
Contributor

Looks like this broke the bots:
https://ci.swift.org/job/oss-swift_tools-RA_stdlib-RDA_test-simulator/3152

@aschwaighofer aschwaighofer mentioned this pull request Apr 29, 2017
Merged
@natecook1000 natecook1000 mentioned this pull request May 1, 2017
Merged
@rintaro rintaro mentioned this pull request Jul 21, 2017
Merged
@natecook1000 natecook1000 deleted the nc-dictionary branch October 4, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@airspeedswift airspeedswift Awaiting requested review from airspeedswift

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natecook1000 @DougGregor @aschwaighofer