Prevent committing tests with .only.
#1883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plemarquand
requested review from
0xTim,
adam-fowler and
award999
as code owners
award999
approved these changes
Oct 10, 2025
plemarquand
force-pushed
the
no-moka-only
branch
2 times, most recently
from
e45cd19 to
eeb7b87
Compare
Adds an eslint rule for mocha tests and suites marked with .only, including a version for our tests/suites wrapped with tag functionality. Adds eslint in to the precommit hook in addition to running the formatter.
plemarquand
force-pushed
the
no-moka-only
branch
from
eeb7b87 to
341fb27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an eslint rule for mocha tests and suites marked with .only, including a version for our tests/suites wrapped with tag functionality.
Adds eslint in to the precommit hook in addition to running the formatter.
Tasks
Required tests have been writtenDocumentation has been updatedAdded an entry to CHANGELOG.md if applicable