Suggest "Open Documentation" when toolchain not found #1939
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can warn that they need to fully quit if the toolchain was installed while VSCode was open Issue: swiftlang#1937
plemarquand
approved these changes
Nov 17, 2025
plemarquand
reviewed
Nov 17, 2025
| The Swift extension automatically detects installations of the Swift toolchain in your environment. It looks for a `swift` binary available in `PATH` and, if one cannot be found, prompts you to [install a toolchain from Swift.org](https://www.swift.org/install). | ||
|
|
||
| <div class="warning" markdown="1"> | ||
| If you install a toolchain or Swiftly while VS Code is open, you likely will need to fully quit VS Code and then reopen it. This makes sure the extension host gets the updated PATH so that extension can find the toolchain. |
Contributor
There was a problem hiding this comment.
nit: remove the ambiguity
Suggested change
| If you install a toolchain or Swiftly while VS Code is open, you likely will need to fully quit VS Code and then reopen it. This makes sure the extension host gets the updated PATH so that extension can find the toolchain. | |
| If you install a toolchain or Swiftly while VS Code is open, fully quit VS Code and then reopen it. This makes sure the extension host gets the updated PATH so that extension can find the toolchain. |
Contributor
Author
There was a problem hiding this comment.
Ah shoot only saw suggestion after merge, I'll put it into another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Can warn that they need to fully quit if the toolchain was installed while VSCode was open
Issue: #1937
Tasks
[ ] Required tests have been written