feat: Implement permission requirements for commands #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement permission requirements for commands.
Type of Change
Please delete options that are not relevant.
Related Issues
Fixes #(issue number)
Closes #(issue number)
Related to #(issue number)
Changes Made
Detailed Changes
List the specific changes made:
permissions
parameter toCommand
attribute constructorICommandService.RegisterCommand
method to accept permission requirementsTesting
Test Environment
Test Cases
Describe the test cases you've run:
[Command("tt6", permissions: "tt6")]
) properly check user permissionsBreaking Changes
List any breaking changes and migration steps:
CommandService
constructor now requiresIPlayerManagerService
andIPermissionManager
parametersPerformance Impact
Details: Permission checking only occurs when commands are executed, with minimal overhead.
Checklist
Screenshots/Videos (if applicable)
Additional Notes
This feature enhances server security by allowing administrators to control command access. The implementation is backward-compatible, with empty permission strings allowing unrestricted access to maintain existing functionality.
For Maintainers